SmileyAdd (fixed) discussion

[borkra]

Actually, no. It does work with multiple background colors. That's how I did it from the beginning (using CHARFORMAT2 to obtain the background at the current selection).

The main problem is/was that smileyadd, when replacing the smileycodes, has no idea whether the current text selection belongs to an incoming or outgoing message or maybe a nickname. So, the only way to get the background color to create the "transparent" (it's only faked transparency) icon is to use EM_GETCHARFORMAT for the current selection.

A "manual" way to set the background color via a service parameter would still be useful in some situations though.

To correct Nightwish here. The described logic was in the smileyadd plugin originally but was enabled only in tabsrmm version of it. Only in recent versions I merged it into the main line (as well as other tabsrmm specific code so that there is no plugin specific code any more) so it is avilable to users of other SRMMs.

[Nightwish]

To correct Nightwish here. The described logic was in the smileyadd plugin originally but was enabled only in tabsrmm version of it. Only in recent versions I merged it into the main line (as well as other tabsrmm specific code so that there is no plugin specific code any more) so it is avilable to users of other SRMMs.

What about the dialog box subclassing code? Does your version detect tabsrmm and disable it (because its not needed and may cause problems).

Another suggestion (and something which I implemented for my version) is creating the smiley selection window with the parent set to the window handle passed in wParam. Reason: Avoid switching transparency to the "inactive" value when the smiley window gets activated (which is annoying). The WM_ACTIVATE handler of the message container checks the parent of the window which gets activated, and if it matches the containers window handle, it doesn't change transparency.

[Faith Healer]

Another suggestion (and something which I implemented for my version)

The main question - can in be merged in ONE module?
different smileyadd versions for different *SR*MM* - it's a bit stupid :)

[Nightwish]

The main question - can in be merged in ONE module?
different smileyadd versions for different *SR*MM* - it's a bit stupid :)

Apparently, it's already done. I'am using borkras version and it works fine with tabsrmm. I don't know if it works with other SRMMs, but I think it does.

The suggested change (setting the parent window) wouldn't affect other SRMMs, because either they don't use the service at all or they set wParam to 0 which would result in exactly the same behaviour as it already is in smileyadd - create the smiley selection window with 0 as its parent.

[borkra]

What about the dialog box subclassing code? Does your version detect tabsrmm and disable it (because its not needed and may cause problems).

Another suggestion (and something which I implemented for my version) is creating the smiley selection window with the parent set to the window handle passed in wParam. Reason: Avoid switching transparency to the "inactive" value when the smiley window gets activated (which is annoying). The WM_ACTIVATE handler of the message container checks the parent of the window which gets activated, and if it matches the containers window handle, it doesn't change transparency.

Yes, "my" version disables dialog box subclassing for tabsrmm.
I am not sure how to answer your last comment, I will look into it.

[Nightwish]

Yes, "my" version disables dialog box subclassing for tabsrmm.
I am not sure how to answer your last comment, I will look into it.

Very easy.

In services.cpp / ShowSmileySelectionCommand()

HWND smileyWindow = CreateDialogParam(g_hInst, MAKEINTRESOURCE(IDD_SMLTOOL), (HWND)wParam, 
                                          DlgProcSmileyToolWindow, (LPARAM) &stwp);

Note the (HWND)wParam instead of the 0. That's the only change...

[Faith Healer]

Apparently, it's already done. I'am using borkras version and it works fine with tabsrmm.

:)

Yes, "my" version disables dialog box subclassing for tabsrmm.

Btw, are you going to support SmileyAdd ot just fixing it's bugs?

Can you add please regular expressions to SmileyAdd - it would be VERY useful thing:
http://daniel.haxx.se/projects/mail2sms/regex.shtml

I hope it's not too complicated

[borkra]

:)


Btw, are you going to support SmileyAdd ot just fixing it's bugs?

Can you add please regular expressions to SmileyAdd - it would be VERY useful thing:
http://daniel.haxx.se/projects/mail2sms/regex.shtml

I hope it's not too complicated

At first I will fix bugs so it would work on peoples PCs (and my own too!!!). Then I will look into new features as time allows.

[nullbie]

Some time ago I was thinking about creating replacement for smileyadd with support for regular expressions, but no luck, I haven't got enough time.... But if you are going to add this feature, this link I've found may be useful for you: http://www.bigredswitch.com/blog/archives/000034.html. There you can find some regex libraries for C/C++ with brief descriptions of their benefits.

[borkra]

:)


Btw, are you going to support SmileyAdd ot just fixing it's bugs?

Can you add please regular expressions to SmileyAdd - it would be VERY useful thing:
http://daniel.haxx.se/projects/mail2sms/regex.shtml

I hope it's not too complicated

Can you guys explain to me why do you want regular expressions support.
I know it's a "cool" thing. But are there any other benefits? What kind of features it will provide to end user which he/she don't have already?

Very easy.

In services.cpp / ShowSmileySelectionCommand()

HWND smileyWindow = CreateDialogParam(g_hInst, MAKEINTRESOURCE(IDD_SMLTOOL), (HWND)wParam, 
                                          DlgProcSmileyToolWindow, (LPARAM) &stwp);

Note the (HWND)wParam instead of the 0. That's the only change...

Nightwish won't it be better to define a different version of API and SMADD_SHOWSEL rather then define a parameter which have not been used before. I looked at your code and you made this change very recently and it still in beta

This is generally fine, but this approach fails when it comes to supporting multiple background colours e.g. different background colour for incoming and outgoing messages. That's why bkgColor field may come in handy...

the_leech,

I verified current smileyadd operation with scriver and different colors (the scenario you described above). It seem to work correctly. Let me know if you still need the change.